Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.13] Bump addon-manager to v8.9.1 #77623

Merged

Conversation

@MrHohn
Copy link
Member

commented May 9, 2019

Bumping addon-manager version in manifests to pick up the latest base image debian-base:v1.0.0.

Ref #76405.

Bump addon-manager to v8.9.1
- Rebase image on debian-base:v1.0.0
Bump addon-manager to v8.9.1
- Rebase image on debian-base:v1.0.0
@MrHohn

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

/kind bug
/priority important-soon
/assign @tallclair

@tallclair

This comment has been minimized.

Copy link
Member

commented May 9, 2019

There's some inconsistency here - the linked PR is bumping to v9.0.1 but this is bumping to v8.9.1.

Is that intentional? Either way, please update the PR description to be accurate.

@MrHohn MrHohn changed the title Manual cherry pick of #77282: Bump addon-manager to v8.9.1 Bump addon-manager to v8.9.1 May 9, 2019

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

Right, that is intentional. Updated title and description. PTAL thanks!

@MrHohn MrHohn changed the title Bump addon-manager to v8.9.1 [1.13] Bump addon-manager to v8.9.1 May 9, 2019

@tallclair

This comment has been minimized.

Copy link
Member

commented May 14, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label May 14, 2019

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

Thanks Tim!
/assign @tpepper
for cherrypick approval.

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

Wanted to see if anyone can help approve this. Thanks!
/assign @bowei @MaciekPytel

@MaciekPytel

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel, MrHohn, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MaciekPytel

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

@aleksandra-malinowska Can you cherry-pick approve?

@aleksandra-malinowska

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

Deadline for cherry-picks to 1.13.7 was Monday, June 3rd. Approving the cherry-pick now would delay this release, since there wouldn't be enough time for all the tests to run. Unless it's super urgent, let's merge it later this week.

/hold

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

@k8s-ci-robot k8s-ci-robot merged commit 6e79b18 into kubernetes:release-1.13 Jun 10, 2019

20 checks passed

cla/linuxfoundation MrHohn authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.