Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix public IPs issues when multiple clusters are sharing the same resource group #77630

Merged
merged 1 commit into from May 9, 2019

Conversation

@feiskyer
Copy link
Member

commented May 9, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug
/sig azure
/priority important-soon

What this PR does / why we need it:

Fix public IPs issues when multiple clusters are sharing the same resource group.

To support this, a new tag "kubernetes-cluster-name" is added to public IP which indicates the kubernetes cluster name (set by kube-controller-manager ----cluster-name='cluster-name').

And for backward compatibility, the public IPs provisioned by old releases would still be supported.

Which issue(s) this PR fixes:

Fixes #77511

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix public IPs issues when multiple clusters are sharing the same resource group.

action required: 

* If the cluster is upgraded from old releases and the same resource group would be shared by multiple clusters, please recreate those LoadBalancer services or add a new tag 'kubernetes-cluster-name: <cluster-name>' manually for existing public IPs.
* For multiple clusters sharing the same resource group, they should be configured with different cluster name by `kube-controller-manager --cluster-name=<cluster-name>`

/assign @andyzhangx

Add support of shared resource group for Azure public IP
To support this, a new tag "kubernetes-cluster-name" is added to public
IP which indicates the kubernetes cluster name (set in kube-controller-manager).
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andyzhangx
Copy link
Member

left a comment

code LGTM, could you also add an example about how to use kubernetes-cluster-name in kube-controler-manager

@k8s-ci-robot k8s-ci-robot added the lgtm label May 9, 2019

@andyzhangx
Copy link
Member

left a comment

/lgtm

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

could you also add an example about how to use kubernetes-cluster-name in kube-controler-manager

added in the release note (action required part).

@k8s-ci-robot k8s-ci-robot merged commit e9af72c into kubernetes:master May 9, 2019

20 checks passed

cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

Provider Azure automation moved this from In progress to Done May 9, 2019

@feiskyer feiskyer deleted the feiskyer:cluster-name-tag branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.