Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add legacy cloud providers unit tests to `make test` #77704

Merged

Conversation

@khenidak
Copy link
Contributor

commented May 9, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
the PR adds ./staging/src/k8s/legacy-cloud-providers to list of directories discovered by unit tests/

Does this PR introduce a user-facing change?:
NONE

Once merged, `legacy cloud providers` unit tests will run as part of ci, just as they were before they move from `./pkg/cloudproviders/providers` 

@kubernetes/sig-cloud-provider

@andrewsykim FYI

@andrewsykim

This comment has been minimized.

Copy link
Member

commented May 9, 2019

/kind cleanup
/sig cloudprovider testing

@andrewsykim

This comment has been minimized.

Copy link
Member

commented May 9, 2019

LGTM

/assign @dims

@andrewsykim

This comment has been minimized.

Copy link
Member

commented May 9, 2019

/priority imporant-soon

@dims

This comment has been minimized.

Copy link
Member

commented May 9, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, khenidak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewsykim

This comment has been minimized.

Copy link
Member

commented May 10, 2019

/lgtm

@feiskyer

This comment has been minimized.

Copy link
Member

commented May 10, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot merged commit 32b37f5 into kubernetes:master May 10, 2019

20 checks passed

cla/linuxfoundation khenidak authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.