Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix some service tags not supported issues for Azure LoadBalancer service #77719
What type of PR is this?
What this PR does / why we need it:
Azure cloud provider has a limited support for service tags by annotations:
But according to https://docs.microsoft.com/en-us/azure/virtual-network/security-overview#service-tags, there are actually much more service tags than this list. Hence, errors would happen if the service tag is not included in the above list.
This PR fixes the issue by removing the static list from the cloud provider and let Azure API validate whether the service tag is supported or not. If illegal service tags are provided, error events would be sent for the service.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: feiskyer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
@feiskyer: The following test failed, say