Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: Remove ClusterConfiguration from InitConfiguration in v1beta2 #77739

Merged
merged 1 commit into from May 29, 2019
Commits on May 29, 2019
  1. kubeadm: Remove ClusterConfiguration from InitConfiguration in v1beta2

    rosti committed May 8, 2019
    Ever since v1alpha3, InitConfiguration is containing ClusterConfiguration
    embedded in it. This was done to mimic the internal InitConfiguration, which in
    turn is used throughout the kubeadm code base as if it is the old
    MasterConfiguration of v1alpha2.
    
    This, however, is confusing to users who vendor in kubeadm as the embedded
    ClusterConfiguration inside InitConfiguration is not marshalled to YAML.
    For this to happen, special care must be taken for the ClusterConfiguration
    field to marshalled separately.
    
    Thus, to make things smooth for users and to reduce third party exposure to
    technical debt, this change removes ClusterConfiguration embedding from
    InitConfiguration.
    
    Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
You can’t perform that action at this time.