Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds staging directory for kubectl code #77762

Merged
merged 1 commit into from Jun 1, 2019

Conversation

@seans3
Copy link
Contributor

commented May 10, 2019

  • Creates staging directory for kubectl code
  • Adds the following initial files to this directory:
    • .github/PULL_REQUEST_TEMPLATE.md
    • code-of-conduct.md
    • LICENSE
    • OWNERS
    • README.md
    • SECURITY_CONTACTS
  • Code committed to the kubectl staging directory will be published to: https://github.com/kubernetes/kubectl

For more infomation please see the initial KEP describing kubectl staging move:
kubernetes/enhancements#949

as well as:
kubernetes/enhancements#1028

NONE

/kind cleanup
/sig cli
/area kubectl

@seans3

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

/priority longterm-important

@k8s-ci-robot k8s-ci-robot requested review from lavalamp and liggitt May 10, 2019

@seans3

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

/assign @lavalamp
/assign @liggitt

@seans3

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

/assign @soltysh
/assign @pwittrock

@seans3 seans3 force-pushed the seans3:kubectl-staging-dir branch from cbef242 to d9de69b May 10, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented May 10, 2019

/test pull-publishing-bot-validate

@seans3

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

/priority longterm-important

@seans3 seans3 changed the title Adds staging directory for kubectl code [WIP] Adds staging directory for kubectl code May 13, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented May 13, 2019

needs publishing rules update (see verify failures)

is the kubectl repo cleared out and ready for this to publish to it?

@seans3 seans3 force-pushed the seans3:kubectl-staging-dir branch from d9de69b to 1850384 May 16, 2019

@k8s-ci-robot k8s-ci-robot added sig/storage and removed lgtm labels May 29, 2019

@seans3 seans3 force-pushed the seans3:kubectl-staging-dir branch 2 times, most recently from e404c4e to a44a28b May 29, 2019

@seans3

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

/retest

@seans3 seans3 force-pushed the seans3:kubectl-staging-dir branch from a44a28b to d7bb4e0 May 30, 2019

@seans3

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

@nikhita

This comment has been minimized.

Copy link
Member

commented May 30, 2019

@seans3 lgtm overall, but looks like the commit message needs update :)

@seans3 seans3 force-pushed the seans3:kubectl-staging-dir branch 3 times, most recently from 4ffc09d to 8bcc98e May 30, 2019

@seans3

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Sean Sullivan lgtm overall, but looks like the commit message needs update :)

Thanks for pointing that out. I made a mistake while squashing the commit :)

@seans3 seans3 force-pushed the seans3:kubectl-staging-dir branch from 8bcc98e to 8ccc2af May 30, 2019

@nikhita
Copy link
Member

left a comment

🚀

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels May 30, 2019

@nikhita

This comment has been minimized.

Copy link
Member

commented May 30, 2019

/priority important-soon

@nikhita

This comment has been minimized.

Copy link
Member

commented May 30, 2019

/retest

1 similar comment
@seans3

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@seans3: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-csi-serial 2f17ecf link /test pull-kubernetes-e2e-gce-csi-serial
pull-kubernetes-e2e-gce-storage-slow 2f17ecf link /test pull-kubernetes-e2e-gce-storage-slow

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nikhita

This comment has been minimized.

Copy link
Member

commented May 30, 2019

/retest

@claurence

This comment has been minimized.

Copy link

commented May 31, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 31, 2019

@seans3

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 603bb74 into kubernetes:master Jun 1, 2019

20 of 21 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation seans3 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Job succeeded.
Details
tide In merge pool.
Details
@nikhita

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

https://github.com/kubernetes/kubectl has been published! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.