Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful custom resource storage teardown #77816

Merged
merged 1 commit into from May 14, 2019

Conversation

@liggitt
Copy link
Member

commented May 13, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Tracks in-flight requests for short-lived custom resource requests and waits to destroy backing storage until those in-flight requests are finished. Matches behavior for in-tree resources.

Which issue(s) this PR fixes:
Fixes #68508

Does this PR introduce a user-facing change?:

Fixed a transient error API requests for custom resources could encounter while changes to the CustomResourceDefinition were being applied.

/sig api-machinery
/cc @jpbetz @sttts
/priority important-soon

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt force-pushed the liggitt:graceful-crd branch from d90cdb3 to ee215ba May 13, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

comments addressed

@liggitt

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiextensions-apiserver/test/integration/versioning_test.go#L80

let's remove this line?

no, we still need to give time for the CRD update to trigger replacing the handler. This just fixes spurious errors, it doesn't make the handler swap instantaneous.

@jpbetz

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 14, 2019

@jpbetz jpbetz referenced this pull request May 14, 2019
1 of 2 tasks complete
@fejta-bot

This comment has been minimized.

Copy link

commented May 14, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit c85c0e4 into kubernetes:master May 14, 2019

20 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:graceful-crd branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.