Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 198.51.100.0/24 to non-masq ranges. #77844

Merged
merged 1 commit into from May 17, 2019

Conversation

@grayluck
Copy link
Contributor

commented May 14, 2019

Adding 198.51.100.0/24 to non-masq rules which was missing in the previous PR.

The previous PR: #77458

/kind feature
/kind bug

Special notes for your reviewer:
/assign bowei

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Hi @grayluck. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grayluck

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

/sig network
/priority important-soon

@yue9944882

This comment has been minimized.

Copy link
Member

commented May 14, 2019

/ok-to-test

@bowei

This comment has been minimized.

Copy link
Member

commented May 14, 2019

can we group these by RFC

@grayluck

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

can we group these by RFC

It's currently in the order of IP section of the CIDRs, with local traffic at top, which to me is more natural and easier to seek for. But I am open at this.

@grayluck

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

/retest

@grayluck

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

/hold
Need a new IP masq agent build.

@grayluck grayluck force-pushed the grayluck:one-more-ip branch from c9c0674 to 0f1100a May 15, 2019

@grayluck

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

/hold cancel
Tested: ip masq agent get deployed with:
-A IP-MASQ -d 198.51.100.0/24 -m comment --comment "ip-masq-agent: local traffic is not subject to MASQUERADE" -j RETURN

@grayluck

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

/test pull-kubernetes-integration

@grayluck

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

/test pull-kubernetes-integration

@grayluck grayluck force-pushed the grayluck:one-more-ip branch from 0f1100a to 60b152c May 15, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels May 15, 2019

@grayluck

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

/test pull-kubernetes-verify

@grayluck grayluck force-pushed the grayluck:one-more-ip branch from 60b152c to 15305f0 May 15, 2019

Add 198.51.100.0/24 to non-masq ranges.
Groupped the IP ranges by RFC and type.

Change reference for 198.18.0.0/15 from RFC 2544 to RFC 6815.

@grayluck grayluck force-pushed the grayluck:one-more-ip branch from 15305f0 to 14015d9 May 15, 2019

@grayluck

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

/retest

@bowei

This comment has been minimized.

Copy link
Member

commented May 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 16, 2019

@bowei

This comment has been minimized.

Copy link
Member

commented May 16, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, grayluck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grayluck

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

Thanks for review and comments, Bowei!

@fejta-bot

This comment has been minimized.

Copy link

commented May 16, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot

This comment has been minimized.

Copy link

commented May 16, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented May 17, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented May 17, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit af692da into kubernetes:master May 17, 2019

20 checks passed

cla/linuxfoundation grayluck authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.