Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phase runner to kubeadm reset #77847

Merged
merged 2 commits into from May 16, 2019

Conversation

@yagonobre
Copy link
Member

commented May 14, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Add phase runner to kubeadm reset

Which issue(s) this PR fixes:
Refs kubernetes/kubeadm#1425
Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubeadm: expose the kubeadm reset command as phases

/priority important-soon

@yagonobre yagonobre force-pushed the yagonobre:reset-phase branch from 47b9dcb to d92b0e2 May 14, 2019

@neolit123
Copy link
Member

left a comment

this is a great start @yagonobre
thank you!
/assign @fabriziopandini

the diff LGTM

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, yagonobre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123

This comment has been minimized.

Copy link
Member

commented May 14, 2019

Does this PR introduce a user-facing change?:

i think we should add the release note in this PR - e.g.:

kubeadm: expose the kubeadm reset command as phases
@neolit123
Copy link
Member

left a comment

/lgtm

let's unblock this and amend later if needed.

@k8s-ci-robot k8s-ci-robot added the lgtm label May 15, 2019

@k8s-ci-robot k8s-ci-robot merged commit d823fa2 into kubernetes:master May 16, 2019

20 checks passed

cla/linuxfoundation yagonobre authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@yagonobre

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

Thanks @neolit123 I'll send the remaining prs tomorrow.

@yagonobre yagonobre deleted the yagonobre:reset-phase branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.