Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vmsizelist call in azure disk GetVolumeLimits #77851

Merged
merged 1 commit into from May 23, 2019

Conversation

@andyzhangx
Copy link
Member

commented May 14, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
remove vmsizelist call in azure disk GetVolumeLimits

Which issue(s) this PR fixes:

Fixes #77461

Special notes for your reviewer:
About how to get all VM size list, here is the guide: #77461 (comment)

BTW, there is a side effect for this PR, after this PR, new released VM type would have default max data disk count(16), need to update azure_dd_max_disk_count.go file periodically. @khenidak

/hold
let's hold this PR for a moment until we agree with this side effect

logs from kubelet

May 13 08:56:46 k8s-agentpool-22533604-1 kubelet[3023]: I0513 08:56:46.555260    3023 setters.go:739] Error getting volume limit for plugin kubernetes.io/cinder
May 13 08:56:46 k8s-agentpool-22533604-1 kubelet[3023]: I0513 08:56:46.555293    3023 azure_dd.go:174] got a matching size in getMaxDataDiskCount, VM Size: STANDARD_D4S_V3, MaxDataDiskCount: 8
May 13 08:56:46 k8s-agentpool-22533604-1 kubelet[3023]: I0513 08:56:46.555619    3023 setters.go:739] Error getting volume limit for plugin kubernetes.io/aws-ebs
May 13 08:56:46 k8s-agentpool-22533604-1 kubelet[3023]: I0513 08:56:46.555633    3023 setters.go:739] Error getting volume limit for plugin kubernetes.io/gce-pd

Does this PR introduce a user-facing change?:

remove vmsizelist call in azure disk GetVolumeLimits which happens in kubelet finally

/kind bug
/assign @feiskyer @khenidak
/priority important-soon
/sig azure

/test pull-kubernetes-e2e-aks-engine-azure

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

BTW, there is a side effect for this PR, with this PR, new released VM type would have default max data disk count(16), need to update azure_dd_max_disk_count.go file periodically. @khenidak

/hold
let's hold this PR for a moment until we agree with this side effect

@feiskyer

This comment has been minimized.

Copy link
Member

commented May 14, 2019

BTW, there is a side effect for this PR, with this PR, new released VM type would have default max data disk count(16), need to update azure_dd_max_disk_count.go file periodically. @khenidak

I think this is ok. When new VM type released, we can patch Kubernetes with latest count.

@andyzhangx andyzhangx force-pushed the andyzhangx:azuredisk-max-count branch from 9997295 to 0fd4bc5 May 14, 2019

@feiskyer feiskyer added this to In progress in Provider Azure via automation May 15, 2019

remove vmsizelist call in azure disk
add one comment

add comments

use a new way to generate vm size list

@andyzhangx andyzhangx force-pushed the andyzhangx:azuredisk-max-count branch from 0fd4bc5 to b962361 May 18, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

@andyzhangx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure 9997295 link /test pull-kubernetes-e2e-aks-engine-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feiskyer
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label May 18, 2019

@feiskyer

This comment has been minimized.

Copy link
Member

commented May 18, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Copy link
Member

commented May 23, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit b533613 into kubernetes:master May 23, 2019

20 checks passed

cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.