Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Kubeadm: Add check certificate expiration command #77863
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fabriziopandini
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
May 14, 2019
neolit123 left a comment
thanks for this work @fabriziopandini
during the office hours we expressed that we might not want to add the extra info for
i've added a couple of extra comments.
Feedback from office hours is to always renew certs on upgrade.
Also, we might consider an option to opt-out.
May 16, 2019
Since we are always renewing certificates during an upgrade, I dropped the changes to
The place for this "Action Required" is #76862; I will add this there
Already done in #76862