Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc changes for nodelocaldns graduating to beta #77887

Merged
merged 1 commit into from Jun 1, 2019

Conversation

@prameshj
Copy link
Contributor

commented May 14, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Documentation about nodelocaldns graduating to Beta.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NodeLocal DNSCache graduating to beta.
@prameshj

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network and removed needs-sig labels May 14, 2019

@prameshj

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

do-not-merge/hold

@MrHohn

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@prameshj Is this ready for review?

@prameshj

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

/hold

@prameshj

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@prameshj Is this ready for review?

Not yet, this is a placeholder PR.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@makoscafee: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.10, v1.11, v1.12, v1.13, v1.14, v1.15, v1.16, v1.17, v1.18, v1.4, v1.5, v1.6, v1.7, v1.8, v1.9]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bowei

This comment has been minimized.

Copy link
Member

commented May 15, 2019

/milestone v1.15

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@bowei: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@makoscafee

This comment has been minimized.

Copy link
Member

commented May 15, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 15, 2019

@dstrebel

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Hello! We are starting Code Freeze for 1.15. Is this PR still planned to be included in 1.15?

@prameshj

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/remove-hold

@prameshj

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/hold cancel

@prameshj

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Hello! We are starting Code Freeze for 1.15. Is this PR still planned to be included in 1.15?

Yes it is. Since we are adding more documentation in the website, the change in this PR is sufficient for the README.

@MrHohn

MrHohn approved these changes May 30, 2019

Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, prameshj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented May 30, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

commented May 30, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@prameshj

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

@prameshj

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

/kind documentation
/priority important-soon

@k8s-ci-robot k8s-ci-robot merged commit 0f78b57 into kubernetes:master Jun 1, 2019

21 checks passed

cla/linuxfoundation prameshj authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.