Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create a RuntimeClassManager without a KubeClient #77888

Merged
merged 1 commit into from May 15, 2019

Conversation

@tallclair
Copy link
Member

commented May 14, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:

Fix panic in RuntimeClass manager for standalone kubelets. #68521 was lost in the transition from the dynamic client to the core API client, so this reintroduces the fix.

Does this PR introduce a user-facing change?:

Fix panic logspam when running kubelet in standalone mode.

/sig node
/priority important-soon
/assign @yujuhong

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yujuhong

This comment has been minimized.

Copy link
Member

commented May 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 15, 2019

@k8s-ci-robot k8s-ci-robot merged commit adf6fa6 into kubernetes:master May 15, 2019

20 checks passed

cla/linuxfoundation tallclair authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
k8s-ci-robot added a commit that referenced this pull request May 21, 2019
Merge pull request #77947 from tallclair/automated-cherry-pick-of-#77…
…888-upstream-release-1.14

Automated cherrypick of #77888 upstream release 1.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.