Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honour NewFilteredDynamicSharedInformerFactory namespace argument #77945

Conversation

@michaelfig
Copy link
Contributor

commented May 15, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: NewFilteredDynamicSharedInformerFactory is always cluster-wide. Even though a namespace argument can be provided, it does not honour the argument.

Which issue(s) this PR fixes:

Fixes kubernetes/client-go#601

Special notes for your reviewer: I am uncertain as to how to create a test. The actual namespace used by the DynamicSharedInformerFactory is private, and the fakeClient also does not seem to expose the namespace that is used for the watches and listing. If a test for this trivial change is needed, I would like advice on what APIs to introduce to make verifying the actual namespace possible.

Does this PR introduce a user-facing change?:

k8s.io/client-go/dynamic/dynamicinformer.NewFilteredDynamicSharedInformerFactory now honours namespace argument
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Hi @michaelfig. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelfig

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

/assign @liggitt

@liggitt

This comment has been minimized.

Copy link
Member

commented May 15, 2019

/priority important-soon
/lgtm
/approve

@liggitt

This comment has been minimized.

Copy link
Member

commented May 15, 2019

/ok-to-test

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, michaelfig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented May 15, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

commented May 16, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

/assign @yliaog

@yliaog

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

#76776

fixes this.

@k8s-ci-robot k8s-ci-robot merged commit e0f28e5 into kubernetes:master May 17, 2019

20 checks passed

cla/linuxfoundation michaelfig authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@michaelfig michaelfig deleted the michaelfig:client-go-namespaced-dynamicinformer branch May 17, 2019

nikhita pushed a commit to nikhita/kubernetes that referenced this pull request Jun 13, 2019
Merge pull request kubernetes#77945 from michaelfig/client-go-namespa…
…ced-dynamicinformer

Honour NewFilteredDynamicSharedInformerFactory namespace argument

Kubernetes-commit: e0f28e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.