Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Honour NewFilteredDynamicSharedInformerFactory namespace argument #77945
What type of PR is this?
What this PR does / why we need it: NewFilteredDynamicSharedInformerFactory is always cluster-wide. Even though a namespace argument can be provided, it does not honour the argument.
Which issue(s) this PR fixes:
Special notes for your reviewer: I am uncertain as to how to create a test. The actual namespace used by the DynamicSharedInformerFactory is private, and the fakeClient also does not seem to expose the namespace that is used for the watches and listing. If a test for this trivial change is needed, I would like advice on what APIs to introduce to make verifying the actual namespace possible.
Does this PR introduce a user-facing change?:
Hi @michaelfig. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
May 15, 2019
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing