New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker image for kubelet #7797

Merged
merged 1 commit into from May 6, 2015

Conversation

Projects
None yet
5 participants
@pmorie
Member

pmorie commented May 5, 2015

@vmarmol Not sure who else to tag on this one.

@googlebot googlebot added the cla: yes label May 5, 2015

@vmarmol vmarmol self-assigned this May 5, 2015

@pmorie

This comment has been minimized.

Show comment
Hide comment
@pmorie

pmorie May 5, 2015

Member

A couple things I found about the wheezy backport used by the hypercube image:

  1. Not the right version of libc required for kubelet
  2. No nsenter binary even though util-linux is installed

So, I used centos for now; I'm completely open to suggestions about a better image to use.

Member

pmorie commented May 5, 2015

A couple things I found about the wheezy backport used by the hypercube image:

  1. Not the right version of libc required for kubelet
  2. No nsenter binary even though util-linux is installed

So, I used centos for now; I'm completely open to suggestions about a better image to use.

Show outdated Hide outdated cluster/images/kubelet/.gitignore
@@ -0,0 +1,2 @@
kubelet

This comment has been minimized.

@vmarmol

vmarmol May 5, 2015

Contributor

I think we tend not to add .gitignore files :P

@vmarmol

vmarmol May 5, 2015

Contributor

I think we tend not to add .gitignore files :P

@@ -0,0 +1,9 @@
FROM centos

This comment has been minimized.

@vmarmol

This comment has been minimized.

@pmorie

pmorie May 5, 2015

Member

Is there a way to verify whether util-linux via this list would contain nsenter?

@pmorie

pmorie May 5, 2015

Member

Is there a way to verify whether util-linux via this list would contain nsenter?

This comment has been minimized.

@vmarmol

vmarmol May 5, 2015

Contributor

Outside of trying it out I'm not sure...

@vmarmol

vmarmol May 5, 2015

Contributor

Outside of trying it out I'm not sure...

This comment has been minimized.

@pmorie

pmorie May 5, 2015

Member

Also need to verify we can get the right glibc:

/kubelet: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.14' not found (required by /kubelet)
@pmorie

pmorie May 5, 2015

Member

Also need to verify we can get the right glibc:

/kubelet: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.14' not found (required by /kubelet)

This comment has been minimized.

@pmorie

pmorie May 5, 2015

Member

For the record on the wheezy image the nginx image is based on:

root@d232b986ba56:/# ldd --version
ldd (Debian EGLIBC 2.13-38+deb7u7) 2.13
@pmorie

pmorie May 5, 2015

Member

For the record on the wheezy image the nginx image is based on:

root@d232b986ba56:/# ldd --version
ldd (Debian EGLIBC 2.13-38+deb7u7) 2.13

This comment has been minimized.

@vmarmol

vmarmol May 5, 2015

Contributor

Aaah nvm, let's just use centos

@vmarmol

vmarmol May 5, 2015

Contributor

Aaah nvm, let's just use centos

@vmarmol

This comment has been minimized.

Show comment
Hide comment
@vmarmol

vmarmol May 5, 2015

Contributor

LGTM, nothing really a blocker.

Contributor

vmarmol commented May 5, 2015

LGTM, nothing really a blocker.

@dchen1107

This comment has been minimized.

Show comment
Hide comment
@dchen1107

dchen1107 May 5, 2015

Member

How are we going to handle development version kubelet image?

Member

dchen1107 commented May 5, 2015

How are we going to handle development version kubelet image?

@pmorie

This comment has been minimized.

Show comment
Hide comment
@pmorie

pmorie May 5, 2015

Member

@dchen1107 For that, there's a 'local' target in the makefile. There are a ton of ways we could automate it a bit better -- any preference?

Member

pmorie commented May 5, 2015

@dchen1107 For that, there's a 'local' target in the makefile. There are a ton of ways we could automate it a bit better -- any preference?

@pmorie

This comment has been minimized.

Show comment
Hide comment
@pmorie

pmorie May 6, 2015

Member

Ok, I'm going to remove the gitignore file. Let's make a follow-up issue to make the image uniform with the other 'official' images. To me it would be ideal to just be able to build static binaries and dump them into a scratch image, but there are a couple packages in the kubelet that need native code.

Member

pmorie commented May 6, 2015

Ok, I'm going to remove the gitignore file. Let's make a follow-up issue to make the image uniform with the other 'official' images. To me it would be ideal to just be able to build static binaries and dump them into a scratch image, but there are a couple packages in the kubelet that need native code.

@pmorie

This comment has been minimized.

Show comment
Hide comment
@pmorie

pmorie May 6, 2015

Member

Aight, should be ready to go in, assuming everyone is cool w/ redirect to host logfile as a follow-up.

Member

pmorie commented May 6, 2015

Aight, should be ready to go in, assuming everyone is cool w/ redirect to host logfile as a follow-up.

@vmarmol

This comment has been minimized.

Show comment
Hide comment
@vmarmol

vmarmol May 6, 2015

Contributor

LGTM, will merge tomorrow during merge hours.

Contributor

vmarmol commented May 6, 2015

LGTM, will merge tomorrow during merge hours.

@vmarmol vmarmol added the lgtm label May 6, 2015

jszczepkowski added a commit that referenced this pull request May 6, 2015

Merge pull request #7797 from pmorie/kubelet-image
Create docker image for kubelet

@jszczepkowski jszczepkowski merged commit ce590ff into kubernetes:master May 6, 2015

4 checks passed

Shippable Shippable builds completed
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 49.5%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment