Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add process start time metric to metric probes since they use counters #77975

Merged
merged 1 commit into from Jun 1, 2019

Conversation

@logicalhan
Copy link
Contributor

commented May 16, 2019

Currently the metrics/probes endpoint in the kubelet exposes a set of counters. However, this endpoint does not export the process start time, which is required for counter data fidelity. This PR adds that metric.

What type of PR is this?
/kind bug

metrics added to kubelet endpoint 'metrics/probes':

   process_start_time_seconds 

/sig instrumentation node
/cc @brancz @dashpole

@brancz

This comment has been minimized.

Copy link
Member

commented May 16, 2019

In general this looks good, but CI doesn't seem to agree.

/lgtm

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

To fix kubernetes-verify, please run hack/update-bazel.sh and also copy over the contents of boilerplate as a header (adding the appropriate information i.e. year, etc...).

Thanks :)

@logicalhan logicalhan force-pushed the logicalhan:process-metrics branch from 0ae2d6d to ff4742a May 16, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 16, 2019

@logicalhan logicalhan force-pushed the logicalhan:process-metrics branch from ff4742a to 47baed3 May 16, 2019

@logicalhan logicalhan force-pushed the logicalhan:process-metrics branch from 47baed3 to 2d48b3e May 16, 2019

@brancz

This comment has been minimized.

Copy link
Member

commented May 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 16, 2019

@dashpole

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

/lgtm

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/assign @sttts @tallclair

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/priority important-soon

@sttts

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

/approve

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/milestone v1.15
/assign @vishh

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@logicalhan: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.15
/assign @vishh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

var processStartTime = prometheus.NewGaugeVec(
prometheus.GaugeOpts{
Name: "process_start_time_seconds",
Help: "Start time of the process since unix epoch in seconds.",

This comment has been minimized.

Copy link
@vishh

vishh May 30, 2019

Member

Why is this not in a human readable format - example one of the formats supports by go - https://golang.org/pkg/time/#Time.Format?

This comment has been minimized.

Copy link
@logicalhan

logicalhan May 30, 2019

Author Contributor

Oh, this has to be conformant to the prom go_lang client's implementation of this metric. We opted not to use their implementation because it drags in many other metrics.

This comment has been minimized.

Copy link
@logicalhan

This comment has been minimized.

Copy link
@lavalamp

lavalamp May 31, 2019

Member

Please explain that in a comment for future readers of the code?

@vishh

This comment has been minimized.

Copy link
Member

commented May 30, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan, sttts, vishh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lavalamp

This comment has been minimized.

Copy link
Member

commented May 31, 2019

/milestone v1.15

Seems OK to go in. My comment can be fixed in a followup.

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 31, 2019

@k8s-ci-robot k8s-ci-robot merged commit 408735e into kubernetes:master Jun 1, 2019

20 checks passed

cla/linuxfoundation logicalhan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.