Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Azure network API version to 2018-07-01 #78012

Merged
merged 2 commits into from May 18, 2019

Conversation

@feiskyer
Copy link
Member

commented May 17, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

LoadBalancer Service stuck on pending when EnableTcpReset is enabled on SLB. This is because the Azure network API version 2017-09-0 is too old.

This PR fixes the issue by upgrading the network API version to 2018-07-01.

Which issue(s) this PR fixes:

Fixes #78011

Special notes for your reviewer:

Should cherry pick to 1.13 and 1.14.

Does this PR introduce a user-facing change?:

 Upgrade Azure network API version to 2018-07-01, so that EnableTcpReset could be enabled on Azure standard loadbalancer (SLB).

/sig azure
/kind bug
/priority critical-urgent
/milestone v1.15

feiskyer added some commits May 17, 2019

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

/assign @andyzhangx

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

/assign @liggitt (for vendor updates)

@andyzhangx

This comment has been minimized.

Copy link
Member

commented May 17, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@justaugustus
Copy link
Member

left a comment

@feiskyer -- Any reason to not bump this to an even more recent network API version:

  • 2019-02-01
  • 2018-12-01
  • 2018-11-01
  • 2018-10-01
  • 2018-08-01
@feiskyer

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

@justaugustus for more recent versions, we should also upgrade Azure Go SDK versions. Then, a lot of new dependencies would be introduced, and make it hard for cherry picking.

So the PR only upgrades the API version, and keep the Azure Go SDK version still same.

@justaugustus

This comment has been minimized.

Copy link
Member

commented May 17, 2019

@feiskyer -- totally understand, but I think smaller cherry picks is not a "good enough" reason. I'm worried that that will put us in the same position of letting a very old API version linger around for a long time again.

Are there specific cherry picks that you have in mind?

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

@justaugustus Actually, another reason is too much dependencies conflicts happened when upgrading Azure Go SDK. Until the confliction issues resolved, I don't think we could upgrade any new SDK versions.

See #76656 for more context on the confliction issues.

@justaugustus

This comment has been minimized.

Copy link
Member

commented May 17, 2019

Ahhh, I just read it. We should come up with a plan to get up to date incrementally and get it documented.
Let's chat after KubeCon.

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

pull-kubernetes-e2e-aks-engine-azure is failing consistently. The cluster couldn't be setup. opened #78013 for tracking the failing tests.

@andyzhangx
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 17, 2019

@justaugustus

This comment has been minimized.

Copy link
Member

commented May 17, 2019

/lgtm
/approve

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

/assign @dims

@dims Could you help to approve the go modules updates?

@dims

This comment has been minimized.

Copy link
Member

commented May 17, 2019

@feiskyer should the pull-kubernetes-e2e-aks-engine-azure succeed before we merge this?

/approve
/hold

Hold for the CI job above to go green

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, feiskyer, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

@feiskyer should the pull-kubernetes-e2e-aks-engine-azure succeed before we merge this?

there's a known issue in aks-engine caused by #76953, and the fix for testing failure would be in different repos (aks-engine and test-infra). So it's ok to skip this job.

@justaugustus

This comment has been minimized.

Copy link
Member

commented May 17, 2019

Based on @feiskyer's comment, I'm going to lift the hold on this.
/hold cancel

@fejta-bot

This comment has been minimized.

Copy link

commented May 18, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

commented May 18, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 961ea6b into kubernetes:master May 18, 2019

20 of 21 checks passed

pull-kubernetes-e2e-aks-engine-azure Job failed.
Details
cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

SIG Azure automation moved this from In progress to Done May 18, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

@feiskyer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure 564c6e9 link /test pull-kubernetes-e2e-aks-engine-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feiskyer feiskyer deleted the feiskyer:az-network-2018-07-01 branch May 18, 2019

k8s-ci-robot added a commit that referenced this pull request Jun 4, 2019

Merge pull request #78065 from feiskyer/az-network-2018-07-01-1.13
Automated cherry pick of #78012: Upgrade Azure network API version to 2018-07-01

k8s-ci-robot added a commit that referenced this pull request Jun 4, 2019

Merge pull request #78066 from feiskyer/az-network-2018-07-01-1.14
Automated cherry pick of #78012: Upgrade Azure network API version to 2018-07-01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.