Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CoreDNS version to 1.5.0 and update manifest #78030

Merged
merged 1 commit into from May 18, 2019

Conversation

@rajansandeep
Copy link
Member

commented May 17, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:
Updates the version of CoreDNS to 1.5.0 and also updates the manifests.

Which issue(s) this PR fixes:

Fixes #78003

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

CoreDNS is now version 1.5.0
    - A `ready` plugin has been included to report pod readiness
    - The `proxy` plugin has been deprecated. The `forward` plugin is to be used instead.
    - CoreDNS fixes the logging now that kubernetes’ client lib switched to klog from glog.
@rajansandeep

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

@k8s-ci-robot k8s-ci-robot requested a review from chrisohaver May 17, 2019

@neolit123
Copy link
Member

left a comment

@neolit123

This comment has been minimized.

Copy link
Member

commented May 17, 2019

/retest

@neolit123

This comment has been minimized.

Copy link
Member

commented May 17, 2019

/test pull-kubernetes-e2e-kind

@MrHohn
MrHohn approved these changes May 17, 2019
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, neolit123, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rajansandeep

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

/test pull-kubernetes-e2e-gce-100-performance

1 similar comment
@rosti

This comment has been minimized.

Copy link
Member

commented May 17, 2019

/test pull-kubernetes-e2e-gce-100-performance

@k8s-ci-robot k8s-ci-robot merged commit 648cb98 into kubernetes:master May 18, 2019

21 checks passed

cla/linuxfoundation rajansandeep authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@neolit123

This comment has been minimized.

Copy link
Member

commented May 18, 2019

@rajansandeep
looks like the bump broke kubeadm upgrade e2e:
https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-upgrade-stable-master
72f6954...a67f128

i will have a look, but we might have to revert if there is no apparent solution
cc @fabriziopandini

@rajansandeep

This comment has been minimized.

Copy link
Member Author

commented May 18, 2019

@neolit123 I believe this is due to the CoreDNS ConfigMap retained during upgrade and the ‘ready’ plugin not included in the upgraded version. This causes the coredns pods to report as not-ready.

This is one of the reasons why #78033 is important.

@neolit123

This comment has been minimized.

Copy link
Member

commented May 18, 2019

ok, understood
it would have been better to get #78033 in first to have the migrate logic in place before the version bump.

@chrisohaver

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Can the failing upgrade tests be run ad-hoc in a PR?

@neolit123

This comment has been minimized.

Copy link
Member

commented May 20, 2019

No. Not on a pr remotelly but locally yes using the tool kinder. However i think the failure is reproducible with a regular 1.14 - master upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.