Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement CRI detection for Windows #78053
What type of PR is this?
What this PR does / why we need it:
Special notes for your reviewer:
Manually checked that Docker CRI could be detected on Windows machine. I verified that it was detecting the CRI and not just defaulting to Docker.
Does this PR introduce a user-facing change?:
@rosti I tested this with Docker. Detects the CRI when the docker service is started and works as expected. If I stop the Docker service, it won't detect Docker and will just use it as a default. I verified this by adding some extra logs which I removed for the PR.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing