Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to admission webhook-recognized versions #78135

Merged
merged 11 commits into from May 29, 2019

Conversation

@liggitt
Copy link
Member

commented May 20, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Implements converting objects to webhook-understood versions.

Which issue(s) this PR fixes:
xref kubernetes/enhancements#492
xref https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/00xx-admission-webhooks-to-ga.md#convert-to-webhook-requested-version

Special notes for your reviewer:

Best reviewed a commit at a time, changes follow a fairly reasonable sequence

Does this PR introduce a user-facing change?:

Admission webhooks can now register for a single version of a resource (for example, `apps/v1 deployments`) and be called when any other version of that resource is modified (for example `extensions/v1beta1 deployments`). This allows new versions of a resource to be handled by admission webhooks without needing to update every webhook to understand the new version. See the API documentation for the `matchPolicy: Equivalent` option in MutatingWebhookConfiguration and ValidatingWebhookConfiguration types.

Follow-ups:

  • clarify requestKind, requestResource, requestSubResource are always provided in v1 AdmissionReview
  • document possibility of CRD conversion being asked to convert pre-schema validation

/sig api-machinery
/cc @sttts @jpbetz @caesarxuchao

@liggitt

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

/priority important-soon

@liggitt liggitt force-pushed the liggitt:webhook-conversion branch 3 times, most recently from 1d106ca to 2aeb811 May 21, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt force-pushed the liggitt:webhook-conversion branch from 2aeb811 to de217a1 May 21, 2019

@liggitt liggitt changed the title WIP - Webhook conversion Convert to admission webhook-recognized versions May 21, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented May 21, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sttts

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

needs a rebase

@jpbetz

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

/lgtm

@liggitt liggitt force-pushed the liggitt:webhook-conversion branch from 4997519 to 50f6c2f May 28, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 28, 2019

@liggitt liggitt force-pushed the liggitt:webhook-conversion branch from 50f6c2f to 8c194ea May 28, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

tagging per #78135 (comment)

@liggitt liggitt added lgtm and removed do-not-merge/hold labels May 28, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

/retest

1 similar comment
@liggitt

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit cd9f430 into kubernetes:master May 29, 2019

19 of 20 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:webhook-conversion branch May 29, 2019

@liggitt liggitt moved this from In progress to Completed, 1.15 in API Reviews May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.