Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Cloud provider AWS library should query instance by ID when possible #78140
What type of PR is this?
What this PR does / why we need it:
We tested internally wit batch PVC provisioning benchmark and here are the improvements shown that makes k8s more scalable in aws environment:
Which issue(s) this PR fixes:
This is also the first step towards fixing #78409 , by introduce informer-fed node cache to aws library.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Hi @zhan849. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
May 21, 2019
referenced this pull request
May 22, 2019
Two more questions:
Why is this line in PR description?
I understand fetching by instance-id is more efficient but how does this PR reduces number of
@gnufied I cannot find any - higher failure rate for filter is just our observation and is likely to be account specific
@gnufied I did some test and verified that we do not need additional RBAC for
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing