Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #78137: godeps: update vmware/govmomi to v0.20.1 #78180

Merged

Conversation

@dougm
Copy link
Member

commented May 21, 2019

What type of PR is this?

/kind bug

Which issue(s) this PR fixes:

Fixes #77360

Special notes for your reviewer:

Cannot cherry-pick #78137 (go mod vs godep)

Includes fix for SAML token auth with vSphere and zones API

See also: #75742

Does this PR introduce a user-facing change?:

Fix vSphere SAML token auth when using Zones
Backport of #78137: godeps: update vmware/govmomi to v0.20.1
Cannot cherry-pick #78137 (go mod vs godep)

Includes fix for SAML token auth with vSphere and zones API

Issue #77360

See also: #75742
@dougm

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

/assign @frapposelli

@tpepper

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

/kind bug
/sig vmware
/sig cloud-provider

@rhockenbury

This comment has been minimized.

Copy link

commented May 31, 2019

@frapposelli Would you mind reviewing this before the 1.14.3 deadline (June 3rd)?

@frapposelli

This comment has been minimized.

Copy link
Member

commented May 31, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label May 31, 2019

@rhockenbury

This comment has been minimized.

Copy link

commented Jun 1, 2019

@cblecker

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dougm, frapposelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhockenbury

This comment has been minimized.

Copy link

commented Jun 1, 2019

@k8s-ci-robot k8s-ci-robot merged commit 5c102a4 into kubernetes:release-1.14 Jun 4, 2019

20 checks passed

cla/linuxfoundation dougm authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.