Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure kubernetes master is properly tainted in GCE. #78183

Merged
merged 1 commit into from May 30, 2019

Conversation

@cheftako
Copy link
Member

commented May 21, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Ensures that the node-role.kubernetes.io/master taint is applied to the master with NoSchedule.

Which issue(s) this PR fixes:
Fixes #78147

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Ensures that the node-role.kubernetes.io/master taint is applied to the master with NoSchedule on GCE.
@cheftako

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

/assign @mtaufen

@cheftako

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

/assign @cjcullen

cluster/gce/util.sh Outdated Show resolved Hide resolved
Ensure kubernetes master is properly tainted in GCE.
Factored in mtaufens suggestion.

@cheftako cheftako force-pushed the cheftako:masterTaint branch from 68c2f34 to d574ab0 May 22, 2019

@@ -746,6 +746,7 @@ function construct-linux-kubelet-flags {
#TODO(mikedanese): allow static pods to start before creating a client
#flags+=" --bootstrap-kubeconfig=/var/lib/kubelet/bootstrap-kubeconfig"
#flags+=" --kubeconfig=/var/lib/kubelet/kubeconfig"
flags+=" --register-with-taints=node-role.kubernetes.io/master=:NoSchedule"

This comment has been minimized.

Copy link
@mtaufen

mtaufen May 22, 2019

Contributor

I think it should just be flags+=" --register-with-taints=node-role.kubernetes.io/master:NoSchedule" (omit the final equals sign, just : instead of =:).

This comment has been minimized.

Copy link
@mtaufen

mtaufen May 22, 2019

Contributor

Oh nevermind, you have an empty value. That's confusing lol.

@mtaufen

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 22, 2019

@cjcullen

This comment has been minimized.

Copy link
Member

commented May 29, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, cjcullen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5c31453 into kubernetes:master May 30, 2019

20 checks passed

cla/linuxfoundation cheftako authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.