Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored dependencies to released version #78187

Conversation

@dims
Copy link
Member

commented May 21, 2019

  • github.com/jteeuwen/go-bindata is no longer active
    So we should move to the newer home (github.com/go-bindata/go-bindata)
  • Updating to github.com/go-bindata/go-bindata v3.1.1+incompatible

Updating a bunch of dependencies to released/tagged versions:

  • node:
  • windows, network
  • cloud-provider
    • github.com/d2g/dhcp4client v1.0.0 can drop because #72178 merged (DONE)
    • github.com/xanzy/go-cloudstack v2.4.1+incompatible can drop because #72178 merged (DONE)
  • kubeadm
  • apimachinery:
    • github.com/coreos/go-semver v0.3.0 - @liggitt
    • github.com/emicklei/go-restful v2.9.5+incompatible - @liggitt
    • github.com/evanphx/json-patch v4.2.0+incompatible - @liggitt
    • gopkg.in/yaml.v2 v2.2.2 - @liggitt
    • github.com/json-iterator/go v1.1.6 - @liggitt
  • auth:
    • gopkg.in/square/go-jose.v2 v2.2.2 - @liggitt
  • cli:
    • github.com/spf13/afero v1.2.2 - @liggitt
    • github.com/spf13/cast v1.3.0 - @BenTheElder
    • github.com/spf13/cobra v0.0.4 - @liggitt
    • github.com/spf13/jwalterweatherman v1.1.0 - @liggitt: unfortunate init block
    • github.com/spf13/pflag v1.0.3 - @liggitt
    • github.com/spf13/viper v1.3.2 - @liggitt
    • github.com/magiconair/properties v1.8.1 - @liggitt
    • github.com/mitchellh/go-wordwrap v1.0.0 - @liggitt
    • github.com/russross/blackfriday v1.5.2 - @liggitt
    • github.com/cpuguy83/go-md2man v1.0.10 - @liggitt
    • github.com/fatih/camelcase v1.0.0 - @liggitt
  • apps / cronjob
    • github.com/robfig/cron v1.1.0 - @liggitt
  • trivial or test-only bumps:
    • github.com/mattn/go-shellwords v1.0.5 - @liggitt
    • github.com/kr/pretty v0.1.0 - @liggitt
    • github.com/mvdan/xurls v1.1.0 - @liggitt
    • github.com/jonboulle/clockwork v0.1.0 - @liggitt
    • github.com/client9/misspell v0.3.4 - @liggitt
    • github.com/go-bindata/go-bindata v3.1.1+incompatible - @liggitt
    • github.com/golang/mock v1.2.0 - @liggitt
    • github.com/google/gofuzz v1.0.0 - @liggitt
    • github.com/onsi/ginkgo v1.8.0 - @liggitt
    • github.com/onsi/gomega v1.5.0 - @liggitt
    • github.com/stretchr/testify v1.3.0 - @liggitt

Deleted the dependencies no longer used:
github.com/hashicorp/hcl
github.com/jteeuwen/go-bindata
github.com/kr/fs
github.com/kr/text
github.com/pelletier/go-toml
github.com/pkg/sftp
github.com/shurcooL/sanitized_anchor_name
github.com/spf13/cast

Change-Id: I63674d0fbfc41c51993276b73e2b2bd056c064ec

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Related to: #78434

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot requested review from BenTheElder, brendandburns and kubernetes/dep-approvers May 21, 2019

@dims dims changed the title Update vendored dependencies to released version [WIP] Update vendored dependencies to released version May 21, 2019

@dims dims force-pushed the dims:update-vendored-dependencies-to-released-versions-2 branch 2 times, most recently from a3ea362 to 9ea58ab May 21, 2019

@dims dims force-pushed the dims:update-vendored-dependencies-to-released-versions-2 branch from 8c4b9ed to 9ce5871 May 22, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented May 22, 2019

/test pull-kubernetes-e2e-gce-100-performance

@dims

This comment has been minimized.

Copy link
Member Author

commented May 22, 2019

/retest

@cblecker cblecker requested review from liggitt and removed request for BenTheElder and brendandburns May 22, 2019

dims added some commits Jun 14, 2019

@dims dims force-pushed the dims:update-vendored-dependencies-to-released-versions-2 branch from a0f9b9d to 2df5d85 Jun 19, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

@BenTheElder @mattjmcnaughton @derekwaynecarr - dropped github.com/seccomp/libseccomp from this PR, let's deal with it later

@dims

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

/assign @thockin

Tim, since @liggitt is out, can you please /approve? a bunch of us have reviewed every commit.

Took a lot of iterations to get here. Once this lands will file issues for the remaining ones that we could possibly update (one-by-one) and add a white/black list for those that we think we can never get to a tag (example docker/docker does not use a tag). So we can catch this problem of random SHAs earlier during review. This will help us review when new releases are made for the dependencies we can review change logs for performance/security stuff etc which we cannot do today with random SHA(s).

@thockin

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

Thanks!

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

/test pull-kubernetes-bazel-build

@BenTheElder
Copy link
Member

left a comment

/lgtm
:shipit:

@dims

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

/hold cancel

Thanks everyone!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

@dims: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-csi-serial 123e861 link /test pull-kubernetes-e2e-gce-csi-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

/retest

1 similar comment
@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 00e13db into kubernetes:master Jun 20, 2019

23 checks passed

cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.