Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually revert #76976 #78200

Merged
merged 1 commit into from May 22, 2019

Conversation

@zhan849
Copy link
Contributor

commented May 22, 2019

What type of PR is this?
/kind bug
What this PR does / why we need it:

This PR manually reverts #76976 as we need to have more discussions regarding what is a proper impl. Discussions are continued in #78199

Which issue(s) this PR fixes:
Fixes #78199

Special notes for your reviewer:
I have the revert the change manually based on c8edfa2 from @mcrute

It reverts implementation of GetCandidateZonesForDynamicVolume() and related helpers, constants, tests and library imports.

Release note:

reverts an aws-ebs volume provisioner optimization as we need to further discuss a viable optimization

/sig aws cloud-provider
/priority critical-urgent

/cc @liggitt @smarterclayton @mcrute

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Hi @zhan849. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mcrute

This comment has been minimized.

Copy link
Member

commented May 22, 2019

/ok-to-test

@mcrute

This comment has been minimized.

Copy link
Member

commented May 22, 2019

/retest
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mcrute, zhan849

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a27d3ae into kubernetes:master May 22, 2019

20 checks passed

cla/linuxfoundation zhan849 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.