Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow CRD /scale labelSelectors to be under either status or spec #78234
What type of PR is this?
What this PR does / why we need it:
Note that the server doesn't understand CR Spec.Selector schema, so this means users may need to manually convert Spec.Selector to ScaleStatus.Selector (if Spec.Selector is a complex selector struct).
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
1 similar comment
kubectl downloads openapi spec and evaluate schemas across the entire cluster (including the ones published by other tests). In this case the published schema is of array type with no item and fails the validation in kubectl
referenced this pull request
May 25, 2019
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing