Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #76665: "Use consistent imageRef during container startup" #78261

Merged
merged 1 commit into from May 24, 2019

Conversation

@tallclair
Copy link
Member

commented May 23, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:

This reverts commit 26e3c86 from #76665

The change broke the detection of user ID.

Does this PR introduce a user-facing change?:

Fix broken detection of non-root image user ID

/sig node
/assign @yujuhong
/priority critical-urgent

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yujuhong

This comment has been minimized.

Copy link
Member

commented May 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 23, 2019

@tallclair tallclair referenced this pull request May 23, 2019
@fejta-bot

This comment has been minimized.

Copy link

commented May 23, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

/test pull-kubernetes-kubemark-e2e-gce-big
/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 78254d5 into kubernetes:master May 24, 2019

20 checks passed

cla/linuxfoundation tallclair authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.