Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCE: Disable the Windows defender #78272

Merged
merged 1 commit into from May 24, 2019

Conversation

@yujuhong
Copy link
Member

commented May 24, 2019

This is a workaround for #75148

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Related to #75148

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

GCE: Disable the Windows defender to work around a bug that could cause nodes to crash and reboot
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pjh
pjh approved these changes May 24, 2019
cluster/gce/windows/k8s-node-setup.psm1 Outdated Show resolved Hide resolved
@pjh

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 24, 2019

@yujuhong yujuhong force-pushed the yujuhong:disable-windows-defender branch from e1ae24c to d44fa18 May 24, 2019

@k8s-ci-robot k8s-ci-robot added approved and removed lgtm labels May 24, 2019

@yujuhong yujuhong added the lgtm label May 24, 2019

@yujuhong

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

Addressed the comment. Re-applying the lgtm.

function Disable-WindowsDefender {
# Windows Defender periodically consumes 100% of the CPU, so disable realtime
# scanning. Uninstalling the Windows Feature will prevent the service from
# starting after a reboot.
# TODO(pjh): move this step to image preparation, since we don't want to do a
# full reboot here.
if ((Test-IsTestCluster ${kube_env}) -and
((Get-WindowsFeature -Name 'Windows-Defender').Installed)) {
if (Get-WindowsFeature -Name 'Windows-Defender').Installed) {

This comment has been minimized.

Copy link
@mtaufen

mtaufen May 24, 2019

Contributor

Isn't this missing the beginning paren for the if?

GCE: Disable the Windows defender
This is a workaround for #75148

@yujuhong yujuhong force-pushed the yujuhong:disable-windows-defender branch from d44fa18 to 3b58a5d May 24, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 24, 2019

@mtaufen

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 24, 2019

@xichengliudui

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

/test pull-kubernetes-integration

@fejta-bot

This comment has been minimized.

Copy link

commented May 24, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 4884873 into kubernetes:master May 24, 2019

20 checks passed

cla/linuxfoundation yujuhong authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.