Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler changes to introduce alpha support for Pod Overhead #78319

Merged
merged 2 commits into from Jul 18, 2019

Conversation

@egernst
Copy link
Contributor

commented May 24, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds initial support for alpha-feature PodOverhead as part of the changes described in the Pod Overhead KEP.

Special notes for your reviewer:

This just handles requests, and as is doesn't provide great error messages. May want to do further refactoring, separating explicit requests from the pod overhead in order to provide better error messages.

Introduction of the pod overhead feature to the scheduler.  This functionality is alpha-level as of 
Kubernetes v1.16, and is only honored by servers that enable the PodOverhead feature.gate. 
@egernst

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

PTAL at initial changes in just this commit: faed38c

API changes are handled in #76968

@egernst

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

@k8s-ci-robot k8s-ci-robot requested a review from tallclair May 24, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented May 24, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@@ -33,11 +33,23 @@ func addConversionFuncs(s *runtime.Scheme) error {
func Convert_v1alpha1_RuntimeClass_To_node_RuntimeClass(in *v1alpha1.RuntimeClass, out *node.RuntimeClass, s conversion.Scope) error {
out.ObjectMeta = in.ObjectMeta
out.Handler = in.Spec.RuntimeHandler
if in.Spec.Overhead != nil {
out.Overhead = &node.Overhead{}
if err := Convert_v1alpha1_Overhead_To_node_Overhead(in.Spec.Overhead, out.Overhead, s); err != nil {

This comment has been minimized.

Copy link
@ahg-g

ahg-g May 28, 2019

Member

where is this defined?

This comment has been minimized.

Copy link
@egernst

egernst May 29, 2019

Author Contributor

This is part of the autogenerated changes. See https://github.com/egernst/kubernetes/blob/scheduler-changes/pkg/apis/node/v1alpha1/zz_generated.conversion.go#L89-L92

This is part of the API change PR (which this is unfortunately based on top of )

Show resolved Hide resolved pkg/scheduler/algorithm/predicates/predicates.go
Show resolved Hide resolved pkg/scheduler/algorithm/predicates/predicates_test.go Outdated
Show resolved Hide resolved pkg/scheduler/nodeinfo/node_info.go Outdated
Show resolved Hide resolved pkg/scheduler/algorithm/priorities/resource_allocation.go Outdated
@egernst

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

/milestone 1.16

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

@egernst: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@egernst

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

/cc @bsalamat

@k8s-ci-robot k8s-ci-robot requested a review from bsalamat Jun 5, 2019

@egernst egernst force-pushed the egernst:scheduler-changes branch from af6bacd to 4492f2e Jun 5, 2019

@tallclair

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

/assign @bsalamat

@ahg-g

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

you may want to run ./hack/update-bazel.sh to address the failed build test.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

/lgtm

Can you please open an issue to add a scheduler integration test for this feature? unless you want to add it in this PR :)

@bsalamat
Copy link
Member

left a comment

/approve

Thanks, @egernst!

@egernst egernst force-pushed the egernst:scheduler-changes branch from b62a4d8 to 0a85657 Jul 16, 2019

egernst added some commits May 23, 2019

scheduler: add pod Overhead support for requests
Signed-off-by: Eric Ernst <eric.ernst@intel.com>
pod-overhead: autogenerated code for scheduling changes
Signed-off-by: Eric Ernst <eric.ernst@intel.com>

@egernst egernst force-pushed the egernst:scheduler-changes branch from 0a85657 to 9babbf8 Jul 16, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, egernst

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved and removed needs-rebase labels Jul 16, 2019

@egernst

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@egernst

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

@ahg-g -- I opened an issue: see #80264

I had to rebase due to a trivial conflict. This PR needs a new 'LGTM,' if you're willing.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 17, 2019

@draveness
Copy link
Member

left a comment

/retest
/priority important-soon

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 18, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit ce80aea into kubernetes:master Jul 18, 2019

23 checks passed

cla/linuxfoundation egernst authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.