Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated flag --cleanup-iptables from kube-proxy #78344

Merged
merged 1 commit into from Jun 1, 2019

Conversation

@aramase
Copy link
Contributor

commented May 25, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Removes deprecated flag --cleanup-iptables from kube-proxy

Which issue(s) this PR fixes:

Fixes #78295

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove deprecated flag --cleanup-iptables from kube-proxy
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

Hi @aramase. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vllry

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

/ok-to-test
/priority backlog
/assign @vllry

@vllry

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

That test looks like it might be a flake, let's retry.

/test pull-kubernetes-integration

@vllry

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

Cool, thanks!

/lgtm
/assign @dnardo

@vllry

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

PS - should probably mention in the release note that --cleanup is the successor. --cleanup-iptables was effectively an alias.

@vllry

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

/assign @thockin

@thockin
Copy link
Member

left a comment

Thanks!

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aramase aramase force-pushed the aramase:remove-cleanup-iptables branch from 51b8076 to 3591ac6 May 31, 2019

@aramase aramase force-pushed the aramase:remove-cleanup-iptables branch from 35a68bd to 026567e May 31, 2019

@vllry

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 31, 2019

@aramase

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

/retest

@vllry

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Hey @aramase, apparently we actually have a strict linter for the licence header on file. Can you please undo those whitespace changes? :|

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 31, 2019

Remove deprecated flag --cleanup-iptables from kube-proxy
Remove deprecated flag --cleanup-iptables from kube-proxy

update license

update license

@aramase aramase force-pushed the aramase:remove-cleanup-iptables branch from a075489 to aa07730 May 31, 2019

@aramase

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

@vllry done!

@vllry

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 31, 2019

@claurence

This comment has been minimized.

Copy link

commented May 31, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 31, 2019

@k8s-ci-robot k8s-ci-robot merged commit 9139ade into kubernetes:master Jun 1, 2019

21 checks passed

cla/linuxfoundation aramase authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@aramase aramase deleted the aramase:remove-cleanup-iptables branch Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.