Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote existing E2Es for hostport/HostIP resolution to conformance #78350

Merged

Conversation

@globervinodhn
Copy link
Contributor

commented May 26, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: This PR is a request to promote existing E2Es for service resolution with respect to HostIP and HostPort to conformance.

Which issue(s) this PR fixes: NONE. Requests for promotion of existing E2Es
Fixes #

Special notes for your reviewer: The two existing E2Es that this PR requests to promote and their relevant information is as provided below,

  1. "validates that there is no conflict between pods with same hostPort but different hostIP and protocol"
    --- Takes approximately 45 seconds for successful execution.
    --- The test MUST pass as HostIP resolves to a kubernetes node and usage of the same port in
    different nodes should not be a conflict scenario.
  2. "validates that there exists conflict between pods with same hostPort and protocol but one using 0.0.0.0 hostIP"
    --- Takes approximately 320 seconds for successful execution.

Both the tests are found to be non-flaky and non-disruptive.

Does this PR introduce a user-facing change?: NONE

release-note-none

/area conformance
@mgdevstack @brahmaroutu

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

@globervinodhn: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

Hi @globervinodhn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@globervinodhn

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

/sig network

@globervinodhn

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

/release-note-none

@johnbelamaric

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

/assign
/priority important-soon

Show resolved Hide resolved test/e2e/scheduling/predicates.go Outdated
Show resolved Hide resolved test/e2e/scheduling/predicates.go Outdated
Show resolved Hide resolved test/e2e/scheduling/predicates.go Outdated

@globervinodhn globervinodhn force-pushed the globervinodhn:hostip_hostport_promote branch from 1dc2831 to faf5cda Jun 6, 2019

@johnbelamaric

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

/ok-to-test
/lgtm

@johnbelamaric

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

/milestone v1.16

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

@johnbelamaric: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgdevstack

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

/retest

@bsalamat
Copy link
Member

left a comment

/lgtm
/approve

@johnbelamaric johnbelamaric moved this from In Review to Needs Approval in cncf-k8s-conformance-wg Jul 17, 2019

@bgrant0607

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

For reference, the fields whose scheduling behavior are being exercised are documented here:
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.15/#containerport-v1-core

Thanks!

/milestone v1.16
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 19, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, bsalamat, globervinodhn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bgrant0607 bgrant0607 moved this from Needs Approval to Done in cncf-k8s-conformance-wg Jul 19, 2019

@k8s-ci-robot k8s-ci-robot merged commit 65b0946 into kubernetes:master Jul 19, 2019

19 of 23 checks passed

pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation globervinodhn authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@globervinodhn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce faf5cda link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -206,6 +206,8 @@ test/e2e/node/pre_stop.go: "should call prestop when killing a pod"
test/e2e/scheduling/predicates.go: "validates resource limits of pods that are allowed to run"
test/e2e/scheduling/predicates.go: "validates that NodeSelector is respected if not matching"
test/e2e/scheduling/predicates.go: "validates that NodeSelector is respected if matching"
test/e2e/scheduling/predicates.go: "validates that there is no conflict between pods with same hostPort but different hostIP and protocol"
test/e2e/scheduling/predicates.go: "validates that there exists conflict between pods with same hostPort and protocol but one using 0.0.0.0 hostIP"

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Jul 26, 2019

Member

:/ we should please not use IPv4 only, Kubernetes should be able to be IPv6 as well. cc @aojea

This comment has been minimized.

Copy link
@aojea

aojea Jul 26, 2019

Contributor

I´m working on it, the test is fine, is passing an empty string, but the function I added to translate IPv4 to IPv6 addresses is not checking for that, creating a non-valid IPv6 address
My fault

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Jul 27, 2019

Member

We should also rephrase the test name IMHO.
Thanks for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.