Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure File plugin to csi-translation-lib #78356

Merged
merged 2 commits into from May 30, 2019

Conversation

@andyzhangx
Copy link
Member

commented May 26, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add support for Azure File plugin to csi-translation-lib

in support of csi-migration proposal here: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md

Will help with migration of in-tree Azure File plugin to Azure File CSI.

Also see kubernetes/enhancements#625

Which issue(s) this PR fixes:

Fixes #76685

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add support for Azure File plugin to csi-translation-lib

/assign @feiskyer
/priority important-soon
/sig azure
/sig storage

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 27, 2019

@jsafrane

This comment has been minimized.

Copy link
Member

commented May 28, 2019

I am not migration expert, however I think there are couple of things missing:

  • You need to add azure into list of translated plugins here

  • Corresponding volume plugin should have IsMigratedToCSI filled, e.g. as in AWS. You need to create a new feature gate for each migrated plugin, so they can be migrated separately.

@feiskyer

This comment has been minimized.

Copy link
Member

commented May 28, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 28, 2019

@andyzhangx andyzhangx force-pushed the andyzhangx:csi-translation-azurefile branch from a5c7bd2 to c57494a May 28, 2019

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

/test pull-kubernetes-dependencies

@andyzhangx andyzhangx force-pushed the andyzhangx:csi-translation-azurefile branch from c57494a to 6a5495d May 28, 2019

@davidz627

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 28, 2019

@davidz627

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

/approve

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-gce-csi-serial
/test pull-kubernetes-e2e-gce-device-plugin-gpu
test pull-kubernetes-e2e-gce-storage-slow

@feiskyer
Copy link
Member

left a comment

/lgtm
/retest

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

/assign @saad-ali
could you approve? Thanks.

@jsafrane

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Saad is out of office,

@thockin, @liggitt, can you please approve a little feature? CSI migration requires a separate feature for each volume plugin, so we can migrate each at its own speed.

@liggitt

This comment has been minimized.

Copy link
Member

commented May 29, 2019

/approve
feature gate

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, davidz627, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andyzhangx added 2 commits May 26, 2019
add azure file CSI translation feature gate
fix build error

fix gofmt error

@andyzhangx andyzhangx force-pushed the andyzhangx:csi-translation-azurefile branch from 6a5495d to f5b319c May 30, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 30, 2019

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

/test pull-kubernetes-integration

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

@liggitt there is a rebase, could you approve again, thanks.

@liggitt

This comment has been minimized.

Copy link
Member

commented May 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 30, 2019

@k8s-ci-robot k8s-ci-robot merged commit ade661c into kubernetes:master May 30, 2019

21 checks passed

cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.