Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove deprecated flag --conntrack-max from kube-proxy #78399
What type of PR is this?
What this PR does / why we need it: This PR removes the deprecated --conntrack-max from kube-proxy and also the tests related to this flag
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Hi @rikatz. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
Actually I've missed some Test Cases to be adjusted. They were generating the fuzzers wrongly :)
Also, before sending the PR I did a
Now let's really cross fingers and hope all the CI passes successfully :)
Missed this comment as I was deeply trying to figure out what went wrong ;( But tks for pointing that
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
OK, will wait until this gets merged and open another one following just to some comments cleanup.
Also when the issue gets automatically closed, will reopen it just to associate with the comment cleanup. Is that ok?
Jun 1, 2019
Got it. No problems at all. I’m leaving on vacations on Monday and will be away from computers until 18th, jun. Hope this doesn’t lock any other PRs, will try anyway to follow here and make the necessary changes ASAP.
Thanks for the patience and the mentorship, this community is amazing!