Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions: promote CRD conversion to beta #78426

Merged
merged 5 commits into from May 30, 2019

Conversation

@sttts
Copy link
Contributor

commented May 28, 2019

Requires #77743.

CustomResourcesDefinition conversion via webhooks is promoted to beta. It requires that spec.preserveUnknownFields is set to false.

@sttts sttts changed the title apiextensions: promote CRD conversion to beta WIP: apiextensions: promote CRD conversion to beta May 28, 2019

@k8s-ci-robot k8s-ci-robot requested review from brendandburns and deads2k May 28, 2019

@sttts sttts added this to the v1.15 milestone May 28, 2019

@k8s-ci-robot k8s-ci-robot removed the needs-sig label May 28, 2019

@sttts sttts removed the needs-priority label May 28, 2019

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

/assign @liggitt @jpbetz

@sttts sttts changed the title WIP: apiextensions: promote CRD conversion to beta apiextensions: promote CRD conversion to beta May 28, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented May 28, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

/retest

@jpbetz

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Looks correct to me. Do we typically include a test to ensure that the feature is disabled if the gate is turned off for beta features? (not sure one is needed, just curious what our conventions are)

@k8s-ci-robot k8s-ci-robot added the size/L label May 29, 2019

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

/retest

@@ -343,7 +350,8 @@ func validateCustomResourceConversion(conversion *apiextensions.CustomResourceCo
// ValidateCustomResourceDefinitionSpecUpdate statically validates
func ValidateCustomResourceDefinitionSpecUpdate(spec, oldSpec *apiextensions.CustomResourceDefinitionSpec, established bool, fldPath *field.Path) field.ErrorList {
requireRecognizedVersion := oldSpec.Conversion == nil || hasValidConversionReviewVersionOrEmpty(oldSpec.Conversion.ConversionReviewVersions)
allErrs := validateCustomResourceDefinitionSpec(spec, requireRecognizedVersion, fldPath)

allErrs := validateCustomResourceDefinitionSpec(spec, requireRecognizedVersion, conversionAndPreserveUnknownFields(oldSpec), fldPath)

This comment has been minimized.

Copy link
@liggitt

liggitt May 29, 2019

Member

webhook conversion was previously alpha, I don't think we have to do this check. let's follow-up to remove this and always require preserveUnknownFields:false when using webhook conversion.

This comment has been minimized.

Copy link
@sttts

sttts May 29, 2019

Author Contributor

Follow-up #78501

@liggitt

This comment has been minimized.

Copy link
Member

commented May 29, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label May 29, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented May 29, 2019

needs a rebase

@sttts sttts force-pushed the sttts:sttts-crd-conversion-beta branch from f7cb4e6 to dc6d5b9 May 29, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 29, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

New changes are detected. LGTM label has been removed.

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

Rebased.

@sttts sttts added the lgtm label May 29, 2019

@sttts sttts force-pushed the sttts:sttts-crd-conversion-beta branch from dc6d5b9 to c692875 May 29, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 29, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

New changes are detected. LGTM label has been removed.

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Flake #72493

@k8s-ci-robot k8s-ci-robot merged commit b18846c into kubernetes:master May 30, 2019

19 of 21 checks passed

pull-kubernetes-integration Job triggered.
Details
tide Not mergeable. Job pull-kubernetes-integration has not succeeded.
Details
cla/linuxfoundation sttts authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.