Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate scheduler to use v1beta1 Event API #78447

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@yastij
Copy link
Member

commented May 28, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it: this migrate the scheduler to the v1beta1 Event API (and leaves the Lease to core)

Which issue(s) this PR fixes:

Special notes for your reviewer:

/assign @wojtek-t
/priority important-soon

Does this PR introduce a user-facing change?:

Migrate scheduler to use v1beta1 Event API. action required: any tool targeting scheduler events needs to use v1beta1 Event API
@yastij

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

FYI @bsalamat

@yastij yastij force-pushed the yastij:scheduler-eventf branch 4 times, most recently from 78e4a0b to f34adc5 May 28, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

/test pull-kubernetes-bazel-test

@yastij yastij force-pushed the yastij:scheduler-eventf branch from f34adc5 to f269bac May 29, 2019

@yastij yastij force-pushed the yastij:scheduler-eventf branch 4 times, most recently from 13daf1a to b4b43c0 May 29, 2019

@yastij
Copy link
Member Author

left a comment

@wojtek-t - couple of items that needs your attention

test/integration/scheduler/util.go Outdated Show resolved Hide resolved
cmd/kube-scheduler/app/server.go Show resolved Hide resolved

@yastij yastij force-pushed the yastij:scheduler-eventf branch from b4b43c0 to fdca5f5 May 29, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

@wojtek-t - first commit is from the event expansion PR. will be removed when rebasing on master

@yastij yastij force-pushed the yastij:scheduler-eventf branch 2 times, most recently from 4af45a3 to ae456cf Jul 5, 2019

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

BTW - something is still wrong:

E0705 12:23:23.339945       1 event_broadcaster.go:233] Server rejected event '&v1beta1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"metrics-server-v0.3.3-659666c4b6-2gbmq.15ae825093f9c0a8", GenerateName:"", Namespace:"kube-system", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Finalizers:[]string(nil), ClusterName:"", ManagedFields:[]v1.ManagedFieldsEntry(nil)}, EventTime:v1.MicroTime{Time:time.Time{wall:0xbf3fee2ed402c3b6, ext:43378123049, loc:(*time.Location)(0x2919e40)}}, Series:(*v1beta1.EventSeries)(nil), ReportingController:"default-scheduler", ReportingInstance:"default-scheduler-e2e-e322bfe4e4-674b9-master", Action:"", Reason:"FailedScheduling", Regarding:v1.ObjectReference{Kind:"Pod", Namespace:"kube-system", Name:"metrics-server-v0.3.3-659666c4b6-2gbmq", UID:"517a0e1b-4368-46d8-b04d-f29169e332b9", APIVersion:"v1", ResourceVersion:"379", FieldPath:""}, Related:(*v1.ObjectReference)(nil), Note:"no nodes available to schedule pods", Type:"Warning", DeprecatedSource:v1.EventSource{Component:"default-scheduler", Host:""}, DeprecatedFirstTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeprecatedLastTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeprecatedCount:0}': 'Event "metrics-server-v0.3.3-659666c4b6-2gbmq.15ae825093f9c0a8" is invalid: action: Required value' (will not retry!)

@yastij yastij force-pushed the yastij:scheduler-eventf branch from ae456cf to 54a41db Jul 8, 2019

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

@yastij - apparently, you also need to add fields for which we can select in events api:

involvedObject.kind" is not a known field selector: only "metadata.name", "metadata.namespace"

@yastij yastij force-pushed the yastij:scheduler-eventf branch from 440d0a0 to 97d8756 Jul 11, 2019

@yastij yastij force-pushed the yastij:scheduler-eventf branch from 97d8756 to 71c3fbe Jul 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, wojtek-t, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yastij

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

/retest

cmd/kube-scheduler/app/options/options.go Outdated Show resolved Hide resolved
cmd/kube-scheduler/app/server.go Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
test/integration/util/util.go Show resolved Hide resolved

@yastij yastij force-pushed the yastij:scheduler-eventf branch 2 times, most recently from f3734dc to f92f590 Jul 12, 2019

@wojtek-t
Copy link
Member

left a comment

one last nit - other than that lgtm

pkg/scheduler/scheduler_test.go Outdated Show resolved Hide resolved

@yastij yastij force-pushed the yastij:scheduler-eventf branch from f92f590 to 142288e Jul 12, 2019

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Jul 12, 2019

move scheduler to use v1beta1.events
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>

@yastij yastij force-pushed the yastij:scheduler-eventf branch from 142288e to 08522f8 Jul 12, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 12, 2019

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 12, 2019

@k8s-ci-robot k8s-ci-robot merged commit b0d08f6 into kubernetes:master Jul 12, 2019

22 of 23 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation yastij authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.