Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: rename-ha-flags #78452

Merged
merged 1 commit into from May 30, 2019

Conversation

@fabriziopandini
Copy link
Contributor

commented May 28, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR renames flag “--experimental-control-plane” into “--control-plane” and “--experimental-upload-certs” into “--upload-certs”.

Which issue(s) this PR fixes:
Rif #kubernetes/kubeadm#1567

Special notes for your reviewer:
"--experimental" flags will be preserved for 1 cycle in order to minimize impact to the users

Does this PR introduce a user-facing change?:

kubeadm: flag “--experimental-control-plane” is now deprecated. use “--control-plane” instead
kubeadm: flag “--experimental-upload-certs” is now deprecated. use “--upload-certs” instead

/sig cluster-lifecycle
/area kubeadm
/priority important-soon
@kubernetes/sig-cluster-lifecycle-pr-reviews

/assign @neolit123
/assign @rosti
/cc @yagonobre
/cc @ereslibre

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 28, 2019

@neolit123

This comment has been minimized.

Copy link
Member

commented May 28, 2019

/retest

1 similar comment
@neolit123

This comment has been minimized.

Copy link
Member

commented May 28, 2019

/retest

@yagonobre
Copy link
Member

left a comment

LGTM

@neolit123

This comment has been minimized.

Copy link
Member

commented May 28, 2019

/retest

1 similar comment
@neolit123

This comment has been minimized.

Copy link
Member

commented May 29, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 44a3bf4 into kubernetes:master May 30, 2019

21 checks passed

cla/linuxfoundation fabriziopandini authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@fabriziopandini fabriziopandini deleted the fabriziopandini:rename-ha-flags branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.