Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions: add invalid validation schema regex test #78453

Merged
merged 2 commits into from Jun 1, 2019

Conversation

@sttts
Copy link
Contributor

commented May 28, 2019

Prevents #65470, and is good for published OpenAPI schemas, not to publish invalid data.

CustomResourceDefinition with invalid regular expression in the pattern field of OpenAPI v3 validation schemas are not considere structural.
@liggitt

This comment has been minimized.

Copy link
Member

commented May 28, 2019

/kind cleanup
/priority important-soon
/lgtm

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

/hold

Will use this to add a validation check.

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

We probably need ratcheting here.

/hold

@sttts sttts force-pushed the sttts:sttts-crd-invalid-regex-test branch from 13602cf to 5f65aff May 30, 2019

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

@liggitt updated for structural schemas. Ptal.

@sttts sttts force-pushed the sttts:sttts-crd-invalid-regex-test branch from 5f65aff to 74101af May 30, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented May 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 30, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented May 30, 2019

the validation test is no longer correct since the validation was limited to structural validation

@liggitt liggitt referenced this pull request May 30, 2019

@sttts sttts force-pushed the sttts:sttts-crd-invalid-regex-test branch from 74101af to 0ab6db2 May 30, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 30, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

New changes are detected. LGTM label has been removed.

@sttts sttts added the lgtm label May 30, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

CI is down.

@fejta-bot

This comment has been minimized.

Copy link

commented May 30, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

1 similar comment
@sttts

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 15a01d5 into kubernetes:master Jun 1, 2019

21 checks passed

cla/linuxfoundation sttts authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.