Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubelet flag to disable cadvisor json apis, and mark it deprecrated #78504

Merged
merged 1 commit into from Jun 1, 2019

Conversation

@dashpole
Copy link
Contributor

commented May 29, 2019

What type of PR is this?
/kind cleanup
/priority important-soon
/sig node

What this PR does / why we need it:
As discussed at sig-node, we are going to deprecate the cAdvisor json endpoints starting in 1.15. The endpoint is still enabled by default, and will become disabled by default in 1.17.

This flag only covers the /spec, /stats/, /stats/container/, /stats/{podName}/*, and /stats/{namespace}/*. It does not cover the /metrics/* or /stats/summary endpoints.

Which issue(s) this PR fixes:
Issue: #68522

Does this PR introduce a user-facing change?:

Deprecate kubelet cAdvisor json endpoints

/assign @tallclair @dchen1107

@dashpole dashpole force-pushed the dashpole:deprecate_cadvisor_json branch from 629bfa3 to 785d409 May 30, 2019

@dashpole

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

5 similar comments
@dashpole

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

@dashpole

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

@dashpole

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

@dashpole

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

@dashpole

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

@dashpole

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@dchen1107

This comment has been minimized.

Copy link
Member

commented May 31, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 31, 2019

@dchen1107

This comment has been minimized.

Copy link
Member

commented May 31, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dchen1107 dchen1107 added this to the v1.15 milestone May 31, 2019

@k8s-ci-robot k8s-ci-robot merged commit 6b6bdc7 into kubernetes:master Jun 1, 2019

21 checks passed

cla/linuxfoundation dashpole authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@dashpole dashpole deleted the dashpole:deprecate_cadvisor_json branch Jun 3, 2019

@dashpole dashpole referenced this pull request Jun 10, 2019

Open

Reduce the set of metrics exposed by the kubelet #68522

3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.