Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCE Windows nodes: leave firewall enabled. #78507

Merged
merged 1 commit into from Jun 1, 2019

Conversation

@pjh
Copy link
Contributor

commented May 30, 2019

/kind bug

This PR leaves the Windows firewall enabled on Windows nodes running on GCE. Back when Windows K8s was beta everybody disabled the Windows firewall to prevent any interference with Kubernetes networking. Since then things have stabilized and many users are successfully running K8s clusters with the Windows firewall enabled.

Our Windows prototype job on GCE (https://testgrid.k8s.io/google-windows#windows-prototype&width=20&sort-by-failures=) has been running with the firewall enabled for a couple weeks with no obvious change in the test results.

Windows nodes on GCE now have the Windows firewall enabled by default.
@pjh

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/sig windows
/sig gcp

@pjh

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/cc yujuhong

@k8s-ci-robot k8s-ci-robot requested a review from yujuhong May 30, 2019

@k8s-ci-robot k8s-ci-robot requested review from bowei and gmarek May 30, 2019

@pjh

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/assign yujuhong

@mtaufen

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

/lgtm

@mtaufen

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

/retest

@mtaufen

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

/priority important-soon

@pjh

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

1 similar comment
@pjh

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

@yujuhong

This comment has been minimized.

Copy link
Member

commented May 30, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjh, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pjh

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

/retest

@PatrickLang PatrickLang added this to Backlog in SIG-Windows May 30, 2019

@claurence

This comment has been minimized.

Copy link

commented May 31, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 31, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 1, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 21c9c7a into kubernetes:master Jun 1, 2019

21 checks passed

cla/linuxfoundation pjh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

SIG-Windows automation moved this from Backlog to Done (v1.15) Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.