Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StorageOS volume driver: Remove call to clear mount info if already set #78522

Merged

Conversation

@croomes
Copy link
Contributor

commented May 30, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

#69782 introduced a change to register (in the StorageOS API) the device attachment prior to the volume attachment. The volume attachment code would clear any mount info, causing the StorageOS API to register the mount and then immediately de-register it.

The code to clear the mount info on volume attach is no longer needed. It was used to force-mount a volume if StorageOS thought it was already mounted. In practice it was not needed, and administrators have other ways of clearing stale mount information if required.

Which issue(s) this PR fixes:

Fixes #78517

Special notes for your reviewer:

Can we get this in the next 1.14 patch release?

Does this PR introduce a user-facing change?:

StorageOS volumes now show correct mount information (node and mount time) in the StorageOS administration CLI and UI.

/sig storage
/assign @gnufied @saad-ali
/assign
/ok-to-test
/priority important-soon
/milestone v1.14

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@croomes: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

#69782 introduced a change to register (in the StorageOS API) the device attachment prior to the volume attachment. The volume attachment code would clear any mount info, causing the StorageOS API to register the mount and then immediately de-register it.

The code to clear the mount info on volume attach is no longer needed. It was used to force-mount a volume if StorageOS thought it was already mounted. In practice it was not needed, and administrators have other ways of clearing stale mount information if required.

Which issue(s) this PR fixes:

Fixes #78517

Special notes for your reviewer:

Can we get this in the next 1.14 patch release?

Does this PR introduce a user-facing change?:

StorageOS volumes now show correct mount information (node and mount time) in the StorageOS administration CLI and UI.

/sig storage
/assign @gnufied @saad-ali
/assign
/ok-to-test
/priority important-soon
/milestone v1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Hi @croomes. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@croomes: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

#69782 introduced a change to register (in the StorageOS API) the device attachment prior to the volume attachment. The volume attachment code would clear any mount info, causing the StorageOS API to register the mount and then immediately de-register it.

The code to clear the mount info on volume attach is no longer needed. It was used to force-mount a volume if StorageOS thought it was already mounted. In practice it was not needed, and administrators have other ways of clearing stale mount information if required.

Which issue(s) this PR fixes:

Fixes #78517

Special notes for your reviewer:

Can we get this in the next 1.14 patch release?

Does this PR introduce a user-facing change?:

StorageOS volumes now show correct mount information (node and mount time) in the StorageOS administration CLI and UI.

/sig storage
/assign @gnufied @saad-ali
/assign
/ok-to-test
/priority important-soon
/milestone v1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from gnufied and jsafrane May 30, 2019

Remove call to clear mount info if already set
#69782 introduced a change
to register the device attachment (in the StorageOS API) prior to the
volume attachment.  The volume attachment code would clear any mount
info, causing the StorageOS API to register the mount and then
immediately de-register it.

The code to clear the mount info on volume attach is no longer needed.
It was used to force-mount a volume if StorageOS thought it was already
mounted.  In practice it was not needed, and administrators have other
ways of clearing stale mount information if required.

@croomes croomes force-pushed the croomes:bugfix-78517-storageos-mountref branch from c5a449d to 6d9f465 May 30, 2019

@gnufied

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

/ok-to-test

@saad-ali
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 4, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: croomes, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 4, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@saad-ali saad-ali removed the needs-priority label Jun 4, 2019

@saad-ali saad-ali removed the needs-sig label Jun 4, 2019

@saad-ali

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

/milestone v1.15
bug fix isolated to storage os plugin

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Jun 4, 2019

@k8s-ci-robot k8s-ci-robot merged commit 304a2b1 into kubernetes:master Jun 4, 2019

20 of 21 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation croomes authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.