Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
credentialprovider: Sets homeDirPath to os.UserHomeDir() #78528
What type of PR is this?
What this PR does / why we need it:
Currently, the credential provider will look in the path set in the
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
it looks like the only supported platform this will cause changes on is windows. are there installations setting $HOME in order to use the existing config that will be affected? at the very least, we need to describe the change in a release note and update https://kubernetes.io/docs/concepts/containers/images/#configuring-nodes-to-authenticate-to-a-private-registry with platform-specific details
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
$HOME wouldn't be set in the context of a service, it's a legacy (pre-Windows 7) setting applying to logged in user profiles only. The current codepath was actually resolving that to