Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: revert CoreDNS to 1.3.1 #78545

Merged

Conversation

@neolit123
Copy link
Member

commented May 30, 2019

What this PR does / why we need it:
the CoreDNS upgrade faced some complications since the required Corefile mutations did a huge dependency update.

Revert the CoreDNS version in kubeadm back to 1.3.1, until the problems are resolved.
The 1.5.0 version bump can happen in #78033

Which issue(s) this PR fixes:

xref:
#78030
#78033

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubeadm: revert the CoreDNS version to 1.3.1

/assign @fabriziopandini @chrisohaver @rajansandeep
/kind cleanup
/priority critical-urgent

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from kad and liztio May 30, 2019

@neolit123

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

/milestone v1.15

@chrisohaver

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label May 30, 2019

@neolit123

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

/retest

@fabriziopandini

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

/lgtm

@neolit123

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

/retest

2 similar comments
@neolit123

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

/retest

@neolit123

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

/retest

@neolit123

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

/retest

@chrisohaver

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

FWIW, I refactored the coredns migration library to have zero deps. If #78033 is updated to use the latest commit, it should drop the added dependencies to one (just the migration library itself)

@neolit123

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

/retest

@rajansandeep

This comment has been minimized.

Copy link
Member

commented May 30, 2019

/hold
after rebasing and updating the vendor dep in #78033

@neolit123

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

/hold cancel

@chrisohaver

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@neolit123, This revert is missing the version bumps to cluster/addons/dns/coredns/ from #78030.

@neolit123

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

@chrisohaver it was unclear whether the /cluster bump is going to make it in or not, detached from the kubeadm bump.

@neolit123

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

/retest

1 similar comment
@neolit123

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 16aeec2 into kubernetes:master Jun 3, 2019

21 checks passed

cla/linuxfoundation neolit123 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.