Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route controller: respect rate limit for delete #78581

Merged
merged 1 commit into from Jun 1, 2019

Conversation

@andrewsykim
Copy link
Member

commented May 31, 2019

Signed-off-by: Andrew Sy Kim kiman@vmware.com
Co-authored-by: Khaled Henidak khnidk@microsoft.com

What type of PR is this?
/kind bug

What this PR does / why we need it:
Kal has been pushing the dual-stack effort so decided to take #77761 off his plate. Adds rate limiting checks for delete routes, previously was only for create calls.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Route controller now respects rate limiting to the cloud provider on deletion, previously it was only for create.

/sig network cloudprovider
/priority important-soon
/assign @khenidak @wojtek-t

route controller: respect rate limit for delete
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
Co-authored-by: Khaled Henidak <khnidk@microsoft.com>
@andrewsykim

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 31, 2019

@k8s-ci-robot k8s-ci-robot requested review from cheftako and gmarek May 31, 2019

@wojtek-t

This comment has been minimized.

Copy link
Member

commented May 31, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label May 31, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewsykim

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

/retest

@khenidak

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit ac458e9 into kubernetes:master Jun 1, 2019

21 checks passed

cla/linuxfoundation andrewsykim authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.