Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signature of container runtime PullImage to allow pull w/ secret #7861

Merged
merged 1 commit into from May 6, 2015

Conversation

Projects
None yet
4 participants
@pmorie
Copy link
Member

pmorie commented May 6, 2015

In support of #7627

@googlebot googlebot added the cla: yes label May 6, 2015

@pmorie

This comment has been minimized.

Copy link
Member Author

pmorie commented May 6, 2015

@pmorie

This comment has been minimized.

Copy link
Member Author

pmorie commented May 6, 2015

@vmarmol vmarmol self-assigned this May 6, 2015

@vmarmol

This comment has been minimized.

Copy link
Contributor

vmarmol commented May 6, 2015

LGTM, thanks @pmorie!

vmarmol added a commit that referenced this pull request May 6, 2015

Merge pull request #7861 from pmorie/pull-secrets
Change signature of container runtime PullImage to allow pull w/ secret

@vmarmol vmarmol merged commit d46a2b1 into kubernetes:master May 6, 2015

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Shippable Shippable builds completed
Details
cla/google All necessary CLAs are signed
@yifan-gu

This comment has been minimized.

Copy link
Member

yifan-gu commented May 7, 2015

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.