Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kube-Proxy wait when HNS network not found #78612

Merged
merged 1 commit into from Jun 3, 2019

Conversation

@ksubrmnn
Copy link
Contributor

commented Jun 1, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: Windows Kube-Proxy previously would crash if it did not detect an HNS network. This meant that the CNI would have to be deployed prior to proxy. This PR removes this dependency so proxy can be started before the CNI (such as FlannelD).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Windows kube-proxy will wait for HNS network creation on start
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksubrmnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:retry branch from e3c5d76 to 39aa6ab Jun 1, 2019

@ksubrmnn ksubrmnn changed the title Wait when HNS network not found Kube-Proxy wait when HNS network not found Jun 1, 2019

@ksubrmnn

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2019

@ksubrmnn

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2019

/retest

1 similar comment
@ksubrmnn

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2019

/retest

@madhanrm

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

/lgtm

@madhanrm

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

/milestone v1.15

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

@madhanrm: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michmike

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Jun 1, 2019

@madhanrm

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

/kind bug

@madhanrm

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

/sig windows

@michmike

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

/kind bug

@michmike

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup and removed needs-kind labels Jun 3, 2019

@michmike

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

/kind bug

@michmike

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

/remove-kind cleanup

@k8s-ci-robot k8s-ci-robot merged commit f532d5c into kubernetes:master Jun 3, 2019

21 checks passed

cla/linuxfoundation ksubrmnn authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@neolit123 neolit123 referenced this pull request Jun 10, 2019

Open

tracking issue for Windows support #1393

3 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.