New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restriction that cluster-cidr be a class-b #7862

Merged
merged 1 commit into from May 6, 2015

Conversation

Projects
None yet
5 participants
@cjcullen
Member

cjcullen commented May 6, 2015

We shouldn't restrict the CLUSTER_IP_RANGE to a /16. Some may want smaller, some (cough--GKE--cough) may want a /14.

@googlebot googlebot added the cla: yes label May 6, 2015

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot May 6, 2015

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot commented May 6, 2015

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no and removed cla: yes labels May 6, 2015

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot May 6, 2015

CLAs look good, thanks!

googlebot commented May 6, 2015

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 6, 2015

@zmerlynn

This comment has been minimized.

Show comment
Hide comment
@zmerlynn

zmerlynn May 6, 2015

Member

I assume it psases e2es and all that jazz? LGTM

Member

zmerlynn commented May 6, 2015

I assume it psases e2es and all that jazz? LGTM

@zmerlynn zmerlynn added the lgtm label May 6, 2015

@cjcullen

This comment has been minimized.

Show comment
Hide comment
@cjcullen

cjcullen May 6, 2015

Member

e2e's are still running...

Member

cjcullen commented May 6, 2015

e2e's are still running...

@roberthbailey

This comment has been minimized.

Show comment
Hide comment
@roberthbailey

roberthbailey May 6, 2015

Member

LGTM.

Member

roberthbailey commented May 6, 2015

LGTM.

@mbforbes

This comment has been minimized.

Show comment
Hide comment
@mbforbes

mbforbes May 6, 2015

Contributor

Ping when they're done and I'll merge—thanks!

Contributor

mbforbes commented May 6, 2015

Ping when they're done and I'll merge—thanks!

@mbforbes mbforbes self-assigned this May 6, 2015

@cjcullen

This comment has been minimized.

Show comment
Hide comment
@cjcullen

cjcullen May 6, 2015

Member

e2es are green

Member

cjcullen commented May 6, 2015

e2es are green

mbforbes added a commit that referenced this pull request May 6, 2015

Merge pull request #7862 from cjcullen/cbr0
Remove restriction that cluster-cidr be a class-b

@mbforbes mbforbes merged commit 7426b53 into kubernetes:master May 6, 2015

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Shippable Shippable builds completed
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment