Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable KubeletPodResources on Windows #78668

Merged

Conversation

@mtaufen
Copy link
Contributor

commented Jun 3, 2019

What type of PR is this?
/kind failing-test
/sig node
/sig windows
/priority critical-urgent

What this PR does / why we need it:
The feature caused tests to fail when it was enabled.

Work is in progress to fix the feature, but until that work is complete,
we will disable it in the GCE scripts.

Does this PR introduce a user-facing change?:

kube-up.sh scripts now disable the KubeletPodResources feature for Windows nodes, due to issue #78628.
Disable KubeletPodResources on Windows
The feature caused tests to fail when it was enabled.

- #78628

Work is in progress to fix the feature, but until that work is complete,
we will disable it in the GCE scripts.
@pjh

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 4, 2019

@mtaufen

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

/retest

@yujuhong

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtaufen, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PatrickLang PatrickLang added this to In Progress+Review in SIG-Windows Jun 4, 2019

@k8s-ci-robot k8s-ci-robot merged commit 3cd41a5 into kubernetes:master Jun 4, 2019

21 checks passed

cla/linuxfoundation mtaufen authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

SIG-Windows automation moved this from In Progress+Review to Done (v1.15) Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.