Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix return value of WaitForPodsWithLabelRunningReady #78687

Merged

Conversation

@pohly
Copy link
Contributor

commented Jun 4, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind bug

What this PR does / why we need it:

Because of a := assignment, the anonymous function assigned the pod
list to a local variable instead of the
WaitForPodsWithLabelRunningReady return value which therefore always
was nil.

The correct code is an assignment with = as in WaitForPodsWithLabelScheduled.

Special notes for your reviewer:

Found when using the function outside of Kubernetes. Doesn't seem to affect anything in Kubernetes itself.

Does this PR introduce a user-facing change?:

fix pod list return value of framework.WaitForPodsWithLabelRunningReady
@pohly

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

/sig testing

@pohly

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

/priority soon

Trivial one-line fix that would be nice to have in 1.15.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@draveness

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

/lgtm
/priority important-soon

Because of a := assignment, the anonymous function assigned the pod
list to a local variable instead of the
WaitForPodsWithLabelRunningReady return value which therefore always
was nil.

The correct code is an assignment with = as in WaitForPodsWithLabelScheduled.
@pohly pohly force-pushed the pohly:WaitForPodsWithLabelRunningReady branch from 4e80fdc to baef3e4 Jun 18, 2019
@pohly

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

@draveness I had to rebase, please lgtm again.

Copy link
Member

left a comment

/lgtm

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 18, 2019
@draveness

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 18, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

commented Jun 18, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@pohly

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0e499be into kubernetes:master Jun 18, 2019
23 checks passed
23 checks passed
cla/linuxfoundation pohly authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.