Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
e2e: fix return value of WaitForPodsWithLabelRunningReady #78687
What type of PR is this?
What this PR does / why we need it:
Because of a := assignment, the anonymous function assigned the pod
The correct code is an assignment with = as in WaitForPodsWithLabelScheduled.
Special notes for your reviewer:
Found when using the function outside of Kubernetes. Doesn't seem to affect anything in Kubernetes itself.
Does this PR introduce a user-facing change?:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pohly
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Because of a := assignment, the anonymous function assigned the pod list to a local variable instead of the WaitForPodsWithLabelRunningReady return value which therefore always was nil. The correct code is an assignment with = as in WaitForPodsWithLabelScheduled.
1 similar comment