Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions: validate x-kubernetes-int-or-string in CRs #78815

Merged

Conversation

@sttts
Copy link
Contributor

commented Jun 8, 2019

The go-openapi validation part (i.e. unfolding of x-kubernetes-int-or-string: true into something that go-openapi understands) was missing.

This PR also adds complete tests for nullable, also in combination with x-kubernetes-int-or-string.

Fixes #78817.

CRDs get support for x-kuberntes-int-or-string to allow faithful representation of IntOrString types in CustomResources.
@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 8, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

/retest

@sttts sttts changed the title apiextensions: implement x-kubernetes-int-or-string validation apiextensions: validate x-kubernetes-int-or-string in CRs Jun 8, 2019

@k8s-ci-robot k8s-ci-robot merged commit 5fe9101 into kubernetes:master Jun 8, 2019

22 of 23 checks passed

pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
cla/linuxfoundation sttts authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.