Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions: structural schema unit test coverage #78863

Conversation

@sttts
Copy link
Contributor

commented Jun 10, 2019

/kind cleanup

NONE
@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

/milestone v1.16
/assign

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jun 10, 2019

@sttts sttts force-pushed the sttts:sttts-crd-embedded-resource-items-additionalProperties branch from b018df7 to 10b432b Jun 10, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Jun 10, 2019

} else if s.XEmbeddedResource {
// validate an embedded resource
schemaobjectmeta.Validate(fldPath, interface{}(*schema.Default), nil, true)
}

This comment has been minimized.

Copy link
@sttts

sttts Jun 10, 2019

Author Contributor

@liggitt take a careful look at this ^

@sttts sttts force-pushed the sttts:sttts-crd-embedded-resource-items-additionalProperties branch from 10b432b to 5339b27 Jun 10, 2019

@@ -397,7 +416,7 @@ func TestPrune(t *testing.T) {
}
}
}
`, dontPruneMetaAtRoot: true, schema: &structuralschema.Structural{
`, isResourceRoot: true, schema: &structuralschema.Structural{

This comment has been minimized.

Copy link
@sttts

sttts Jun 10, 2019

Author Contributor

actually neither the old, nor the new name was good, the old one slightly more correct. What this say is that the prune algorithm will skip the TypeMeta and ObjectMeta fields and leave the pruning to our coercion algorithm.

This comment has been minimized.

Copy link
@liggitt

liggitt Jun 10, 2019

Member

should it be isResourceRoot to match the function param name?

This comment has been minimized.

Copy link
@liggitt

liggitt Jun 10, 2019

Member

what it actually controls is whether the root of the schema is treated as a resource, regardless of the XEmbeddedResource setting

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 10, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sttts sttts force-pushed the sttts:sttts-crd-embedded-resource-items-additionalProperties branch from 5339b27 to e521fb8 Jun 10, 2019

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

/retest

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

/assign @roycaihw

@liggitt liggitt added this to Required for GA, in progress in Custom Resource Definitions Jun 12, 2019

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2019

@roycaihw can you take a look at this?

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 26, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e760b03 into kubernetes:master Jun 26, 2019

23 checks passed

cla/linuxfoundation sttts authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions Jun 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.